Removed configWriteCookies setting (closes snowplow#390)

Author: fblundun

src/js/in_queue.js

@@ -51,8 +51,7 @@
 
 		// Page view ID should be shared between all tracker instances
 		var pageViewId = uuid.v4(),
-			trackerDictionary = {},
-			usedCookieNames = {};
+			trackerDictionary = {}
 
 		/**
 		 * Get an array of trackers to which a function should be applied.
@@ -113,11 +112,6 @@
 		 */
 		function createNewNamespace(namespace, endpoint, argmap) {
 			argmap = argmap || {};
-			if ((!argmap.writeCookies) && (argmap.cookieName in usedCookieNames)) {
-				argmap.writeCookies = false;
-			} else {
-				usedCookieNames[argmap.cookieName] = true;
-			}
 			trackerDictionary[namespace] = new TrackerConstructor(functionName, namespace, version, pageViewId, mutSnowplowState, argmap);
 			trackerDictionary[namespace].setCollectorUrl(endpoint);
 		}

src/js/tracker.js

@@ -76,13 +76,12 @@
 	 * 10. forceSecureTracker, false
 	 * 11. useLocalStorage, true
 	 * 12. useCookies, true
-	 * 13. writeCookies, true
+	 * 13. sessionCookieTimeout, 1800
 	 * 14. contexts, {}
 	 * 15. post, false
 	 * 16. bufferSize, 1
 	 * 17. crossDomainLinker, false
 	 * 18. maxPostBytes, 40000
-	 * 19. sessionCookieTimeout, 1800
 	 */
 	object.Tracker = function Tracker(functionName, namespace, version, pageViewId, mutSnowplowState, argmap) {
 
@@ -152,8 +151,6 @@
 			// Default is user agent defined.
 			configCookiePath = '/',
 
-			configWriteCookies = argmap.hasOwnProperty('writeCookies') ? argmap.writeCookies : true,
-
 			// Do Not Track browser feature
 			dnt = navigatorAlias.doNotTrack || navigatorAlias.msDoNotTrack,
 
@@ -579,13 +576,11 @@
 				idCookieComponents[5] = idCookieComponents[4];
 			}
 
-			if (configWriteCookies) {
-				setSessionCookie();
-				// Update currentVisitTs
-				idCookieComponents[4] = Math.round(new Date().getTime() / 1000);
-				idCookieComponents.shift();
-				setDomainUserIdCookie.apply(null, idCookieComponents);
-			}
+			setSessionCookie();
+			// Update currentVisitTs
+			idCookieComponents[4] = Math.round(new Date().getTime() / 1000);
+			idCookieComponents.shift();
+			setDomainUserIdCookie.apply(null, idCookieComponents);
 		}
 
 		/*
@@ -648,7 +643,7 @@
 				lastVisitTs = id[5],
 				sessionIdFromCookie = id[6];
 
-			if (configDoNotTrack && configUseCookies && configWriteCookies) {
+			if (configDoNotTrack && configUseCookies) {
 				cookie.cookie(idname, '', -1, configCookiePath, configCookieDomain);
 				cookie.cookie(sesname, '', -1, configCookiePath, configCookieDomain);
 				return;
@@ -695,7 +690,7 @@
 			sb.add('url', purify(configCustomUrl || locationHrefAlias));
 
 			// Update cookies
-			if (configUseCookies && configWriteCookies) {
+			if (configUseCookies) {
 				setDomainUserIdCookie(_domainUserId, createTs, memorizedVisitCount, nowTs, lastVisitTs, memorizedSessionId);
 				setSessionCookie();
 			}

tests/nonfunctional/in_queue.js

@@ -38,12 +38,10 @@ define([
 	"intern/dojo/node!../../src/js/in_queue"
 ], function(registerSuite, assert, in_queue) {
 
-	var output = 0,
-		writeCookies;
+	var output = 0;
 
 	function mockTrackerConstructor (functionName, namespace, version, sessionId, mutSnowplowState, argmap) {
 		var configCollectorUrl,
-			configWriteCookies = argmap.hasOwnProperty('writeCookies') ? argmap.writeCookies : true,
 			attribute = 10;
 
 		return {
@@ -61,9 +59,6 @@ define([
 			},
 			addAttributeToOutput: function() {
 				output += attribute;
-			},
-			logConfigWriteCookies: function() {
-				writeCookies = configWriteCookies;
 			}
 		}
 	};
@@ -100,13 +95,6 @@ define([
 			assert.equal(output, 29, "Set the attributes of the two trackers individually, then add both to output");
 		},
 
-		"writeCookies properties have been correctly assigned": function() {
-			asyncQueue.push(["logConfigWriteCookies:firstTracker"]);
-			assert.strictEqual(writeCookies, true, "The first tracker is configured to create cookies");
-			asyncQueue.push(["logConfigWriteCookies:sp"]);
-			assert.strictEqual(writeCookies, false, "The second tracker has not been assigned a unique cookie namespace, so cannot create cookies");
-		},
-
 		"Execute a user-defined custom callback": function () {
 			var callbackExecuted = false;
 			asyncQueue.push([function () { callbackExecuted = true; }]);